wxiaoguang d5fa2e7510 Fix restore repo bug, clarify the problem of ForeignIndex (#22776) ...

Fix #22581

TLDR: #18446 made a mess with ForeignIndex and triggered a design
flaw/bug of #16356, then a quick patch #21271 helped #18446, then the
the bug was re-triggered by #21721 .

Related:
* #16356
* BasicIssueContext
https://github.com/go-gitea/gitea/pull/16356/files#diff-7938eb670d42a5ead6b08121e16aa4537a4d716c1cf37923c70470020fb9d036R16-R27
* #18446 
* If some issues were dumped without ForeignIndex, then they would be
imported as ForeignIndex=0
https://github.com/go-gitea/gitea/pull/18446/files#diff-1624a3e715d8fc70edf2db1630642b7d6517f8c359cc69d58c3958b34ba4ce5eR38-R39
* #21271
* It patched the above bug (somewhat), made the issues without
ForeignIndex could have the same value as LocalIndex
* #21721 
    * It re-triggered the zero-ForeignIndex bug.


ps: I am not sure whether the changes in `GetForeignIndex` are ideal (at
least, now it has almost the same behavior as BasicIssueContext in
#16356), it's just a quick fix. Feel free to edit on this PR directly or
replace it.

Co-authored-by: zeripath <art27@cantab.net>

2023-02-07 09:18:52 +08:00

..

file_format_testdata

…

schemas

…

comment.go

Fix restore repo bug, clarify the problem of ForeignIndex (#22776)

2023-02-07 09:18:52 +08:00

downloader.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

error.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

file_format_test.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

file_format.go

Show migration validation error (#22619)

2023-01-27 20:56:00 +08:00

issue.go

Fix restore repo bug, clarify the problem of ForeignIndex (#22776)

2023-02-07 09:18:52 +08:00

label.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

messenger.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

milestone.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

null_downloader.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

options.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

pullrequest.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

reaction.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

release.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

repo.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

retry_downloader.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

review.go

Fix restore repo bug, clarify the problem of ForeignIndex (#22776)

2023-02-07 09:18:52 +08:00

schemas_bindata.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

schemas_dynamic.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

schemas_static.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

uploader.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00