ddmt/gitdts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
14,550 Commits 17 Branches 214 Tags
215d80f6b2a86fd28a1e998e9a0e43866553aee0
Commit Graph

3792 Commits

Author SHA1 Message Date
Jason Song
ab98c3ff43 Merge branch 'main' into feature/bots 2022-12-19 18:26:28 +08:00
zeripath
6e22605793 Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017) 
As recognised in #21841 the rendering of plain text files is somewhat
incorrect when there are ambiguous characters as the html code is double
escaped. In fact there are several more problems here.

We have a residual isRenderedHTML which is actually simply escaping the
file - not rendering it. This is badly named and gives the wrong
impression.

There is also unusual behaviour whether the file is called a Readme or
not and there is no way to get to the source code if the file is called
README.

In reality what should happen is different depending on whether the file
is being rendered a README at the bottom of the directory view or not.

1. If it is rendered as a README on a directory - it should simply be
escaped and rendered as `<pre>` text.
2. If it is rendered as a file then it should be rendered as source
code.

This PR therefore does:
1. Rename IsRenderedHTML to IsPlainText
2. Readme files rendered at the bottom of the directory are rendered
without line numbers
3. Otherwise plain text files are rendered as source code.

Replace #21841

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-17 22:22:25 +02:00
Lunny Xiao
1b32ed014a remove duplicated read file code (#22042) 
Merge the duplicated read file code as one function in reading text file
and readme file.
 2022-12-14 18:11:11 +08:00
KN4CK3R
07461e18d3 Fix condition for is_internal (#22095) 
depends on #22094

Fixes https://codeberg.org/forgejo/forgejo/issues/77

The old logic did not consider `is_internal`.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-12-14 17:16:01 +08:00
Jason Song
6c622137f1 Merge branch 'main' into feature/bots 2022-12-13 09:50:18 +08:00
Lunny Xiao
87c64f655a Fix permission check on issue/pull lock (#22110) 
Fix #21826
 2022-12-12 23:02:51 +08:00
Lunny Xiao
36a2d2f919 Add a simple test for external renderer (#20033) 
Fix #16402
 2022-12-12 20:45:21 +08:00
Jason Song
ef20a02af0 fix: use web.Bind 2022-12-12 18:55:23 +08:00
Jason Song
1c9288f3dd fix: list runners 2022-12-12 18:52:52 +08:00
Jason Song
cc19ab5ced Merge branch 'main' into feature/bots 2022-12-12 17:29:51 +08:00
Jason Song
d4c47acff4 fix: remove useless grpc routers 2022-12-12 17:29:34 +08:00
Jason Song
d41fb40fb5 docs: comment for V1AlphaRoute 2022-12-12 17:29:34 +08:00
Lunny Xiao
6398ca745a refactor bind functions based on generics (#22055) 2022-12-12 16:09:26 +08:00
Lunny Xiao
705fbb46d5 Fix permission check on http push 2022-12-12 14:52:00 +08:00
Jason Song
59c3707da2 Merge branch 'main' into feature/bots 2022-12-12 13:33:24 +08:00
Lunny Xiao
003b4e209c Allow disable code tab (#20805) 
I know some users created a repository in an organization but just use
issues and projects to handle the whole organizations issues. So that
`Code` could be disabled per repository.

<img width="1148" alt="image"
src="https://user-images.githubusercontent.com/81045/184792075-346cb508-b620-4adb-bc9a-cba76fdcb294.png">

It could also become a wiki repository.

<img width="1173" alt="image"
src="https://user-images.githubusercontent.com/81045/184792324-e15c6f68-35c0-4105-ab77-83585ce53672.png">

Co-authored-by: delvh <dev.lh@web.de>
 2022-12-12 13:29:27 +08:00
Jason Song
dfa1b6168d Merge branch 'main' into feature/bots 2022-12-12 10:46:13 +08:00
aceArt-GmbH
352a50d65f Fix sorting admin user list by last login (#22081) 
Admin User Account list sort

`updated_unix` is not the same as "Last Sign-In"
 2022-12-11 18:00:17 -06:00
Lunny Xiao
68704532c2 Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
Jason Song
d378a78c79 Merge branch 'main' into feature/bots 2022-12-09 16:20:28 +08:00
Jason Song
10ebbeca2f chore: rename to action 2022-12-09 15:29:26 +08:00
KN4CK3R
3c59d31bc6 Add API management for issue/pull and comment attachments (#21783) 
Close #14601
Fix #3690

Revive of #14601.
Updated to current code, cleanup and added more read/write checks.

Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andre Bruch <ab@andrebruch.com>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Norwin <git@nroo.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-09 14:35:56 +08:00
Jason Song
266a122ba2 Merge branch 'main' into feature/bots 2022-12-08 18:11:18 +08:00
silverwind
0585ac3ac6 Update go dev dependencies (#22064) 
`golangci-lint`
[deprecated](https://github.com/golangci/golangci-lint/issues/1841) a
bunch of linters, removed them.
 2022-12-08 16:21:37 +08:00
Jason Song
0a85537c79 Support disabling database auto migration (#22053) 
Gitea will migrate the database model version automatically, but it
should be able to be disabled and keep Gitea shutdown if the version is
not matched.
 2022-12-07 09:58:31 -06:00
Jason Song
26b87561b6 fix: deal with empty repo 2022-12-06 18:32:26 +08:00
Jason Song
223782ca4c refactor: rename to actions 2022-12-06 15:16:25 +08:00
Jason Song
56368f3963 refactor: use ctx in models 2022-12-06 14:15:48 +08:00
Jason Song
c07d0c1768 refactor: rename model 2022-12-06 13:48:09 +08:00
Jason Song
f2c7bbb0bc refactor: rename to actions-proto-go 2022-12-06 13:44:23 +08:00
Jason Song
67c5c8868b refactor: rename import alias 2022-12-05 15:57:45 +08:00
Jason Song
5f74b35377 refactor: rename files 2022-12-05 15:52:32 +08:00
Jason Song
704f72017d refactor: rename packages 2022-12-05 15:45:38 +08:00
Jason Song
bd1af5b7f8 Merge branch 'main' into feature/bots 2022-12-05 14:31:00 +08:00
Lunny Xiao
36cbaec54c Fix ListBranches to handle empty case (#21921) 
Fix #21910

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
 2022-12-04 08:57:17 +00:00
Lunny Xiao
0a7d3ff786 refactor some functions to support ctx as first parameter (#21878) 
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2022-12-03 10:48:26 +08:00
Jason Song
b0d6c7b86e chore: use SPDX-License-Identifier 2022-12-02 22:25:31 +08:00
Jason Song
76869e4b76 Merge branch 'main' into feature/bots 2022-12-02 22:17:49 +08:00
Jason Song
f59a74852b Update gitea-vet to check FSFE REUSE (#22004) 
Related to:
- #21840
- https://gitea.com/gitea/gitea-vet/pulls/21

What it looks like when it's working:
https://drone.gitea.io/go-gitea/gitea/64040/1/5

All available SPDX license identifiers: [SPDX License
List](https://spdx.org/licenses/).

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-02 22:14:57 +08:00
Jason Song
3dc5547775 Merge branch 'main' into feature/bots 2022-12-02 21:05:31 +08:00
silverwind
d64063277d Multiple improvements for comment edit diff (#21990) 
- Use explicit avatar size so when JS copies the HTML, the size gets
copied with it
- Replace icon font use with SVG
- Improve styling and diff rendering
- Sort lists in `svg.js`

Fixes: https://github.com/go-gitea/gitea/issues/21924

<img width="933" alt="Screenshot 2022-11-30 at 17 52 17"
src="https://user-images.githubusercontent.com/115237/204859608-f322a8f8-7b91-45e4-87c0-82694e574115.png">

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-12-02 11:42:34 +02:00
Jason Song
b2745bff43 feat: support disable bots completely 2022-12-01 15:27:28 +08:00
Jason Song
847d65d724 Merge branch 'main' into feature/bots 2022-11-30 18:25:36 +08:00
花墨
7020c4afb7 Fix leaving organization bug on user settings -> orgs (#21983) 
Fix #21772

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2022-11-30 17:00:00 +08:00
Jason Song
9808d084ba fix: remove useless codes 2022-11-30 16:07:00 +08:00
Jason Song
3793d55eca fix: commit status 2022-11-29 18:48:00 +08:00
Jason Song
564937a657 feat: bots_service.CreateCommitStatus 2022-11-29 18:21:27 +08:00
Jason Song
04d72d3500 refactor: rename tables to bot_* 2022-11-29 12:34:23 +08:00
Jason Song
797c21de1f Merge branch 'main' into feature/bots 2022-11-29 11:09:20 +08:00
Jason Song
9607750b5e Replace fmt.Sprintf with hex.EncodeToString (#21960) 
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x",
[]byte)`, we should use it as much as possible.

I'm not an extreme fan of performance, so I think there are some
exceptions:

- `fmt.Sprintf("%x", func(...)[N]byte())`
- We can't slice the function return value directly, and it's not worth
adding lines.
    ```diff
    func A()[20]byte { ... }
    - a := fmt.Sprintf("%x", A())
    - a := hex.EncodeToString(A()[:]) // invalid
    + tmp := A()
    + a := hex.EncodeToString(tmp[:])
    ```
- `fmt.Sprintf("%X", []byte)`
- `strings.ToUpper(hex.EncodeToString(bytes))` has even worse
performance.
 2022-11-28 11:19:18 +00:00